Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add sysvar tidb_tso_client_rpc_mode for setting TSO RPC concurrency #56292

Merged
merged 5 commits into from
Sep 26, 2024
Merged

*: Add sysvar tidb_tso_client_rpc_mode for setting TSO RPC concurrency #56292

merged 5 commits into from
Sep 26, 2024
+163 −10

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Sep 25, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #54960

Requires: tikv/pd#8633

Problem Summary:

What changed and how does it work?

  • Update pd client to support concurrent TSO RPC
  • Add sysvar tidb_tso_client_rpc_mode for setting TSO RPC concurrency
  • Add some metrics to the grafana dashboard that would be helpful for concurrent TSO RPC.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add support for multiple TSO RPC requests to be done in parallel. `tidb_tso_client_rpc_mode` is now available for enabling this feature, to reduce GetTS latency, at the expense of higher ops of TSO RPC.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 25, 2024

Hi @MyonKeminta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MyonKeminta MyonKeminta mentioned this pull request Sep 25, 2024
Closed
2 tasks
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2024
@MyonKeminta MyonKeminta marked this pull request as ready for review September 26, 2024 04:10
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 26, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.0544%. Comparing base (1b4b2f0) to head (697df1e).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56292        +/-   ##
================================================
+ Coverage   73.3264%   76.0544%   +2.7280%     
================================================
  Files          1619       1641        +22     
  Lines        446472     454627      +8155     
================================================
+ Hits         327382     345764     +18382     
+ Misses        99034      87329     -11705     
- Partials      20056      21534      +1478
Flag Coverage Δ
integration 51.9523% <52.6315%> (?)
unit 72.4563% <52.6315%> (-0.0602%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 62.9846% <ø> (+17.9518%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-26 04:21:39.488109524 +0000 UTC m=+1712569.228533456: ☑️ agreed by crazycs520.
  • 2024-09-26 04:41:36.546963328 +0000 UTC m=+1713766.287387268: ☑️ agreed by ekexium.

@MyonKeminta
Copy link
Contributor Author

/test check-dev2

@tiprow tiprow
Copy link

tiprow bot commented Sep 26, 2024

@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yudongusa
yudongusa approved these changes Sep 26, 2024
View reviewed changes
Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, ekexium, joey-yez, tangenta, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 26, 2024
@MyonKeminta
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2024

@MyonKeminta: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 119e765 into pingcap:master Sep 26, 2024
25 checks passed
@MyonKeminta MyonKeminta deleted the m/support-parallel-tso-rpc branch September 26, 2024 05:41
@okJiang okJiang mentioned this pull request Sep 26, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@ekexium ekexium ekexium approved these changes

@yudongusa yudongusa yudongusa approved these changes

@joey-yez joey-yez joey-yez approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSO Request Parallelizing
6 participants
@MyonKeminta @tangenta @crazycs520 @ekexium @yudongusa @joey-yez